Skip to content

Conversation

krasimirgg
Copy link
Contributor

@krasimirgg krasimirgg commented Jun 28, 2022

No functional changes intended.

This adapts llvm-wrapper for llvm/llvm-project@dacfa24, which removed ASanGlobalsMetadataAnalysis.

Found via our experimental rust + HEAD llvm bot: https://buildkite.com/llvm-project/rust-llvm-integrate-prototype/builds/11565#0181a72f-75bb-4378-88f0-4c0bca7d03fa/231-505.

This adapts llvm-wrapper for
llvm/llvm-project@dacfa24,
which removed ASanGlobalsMetadataAnalysis.
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 28, 2022
@rust-highfive
Copy link
Contributor

r? @cuviper

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 28, 2022
@krasimirgg krasimirgg changed the title llvm-wrapper: adapt for an LLVM API change llvm-wrapper: adapt for removal of the ASanGlobalsMetadataAnalysis LLVM API Jun 28, 2022
@krasimirgg krasimirgg marked this pull request as ready for review June 28, 2022 14:34
@nikic
Copy link
Contributor

nikic commented Jun 28, 2022

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 28, 2022

📌 Commit fe02ee8 has been approved by nikic

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 28, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 28, 2022
…askrgr

Rollup of 11 pull requests

Successful merges:

 - rust-lang#98548 (rustdoc-json: Allow Typedef to be different in sanity assert)
 - rust-lang#98560 (Add regression test for rust-lang#85907)
 - rust-lang#98564 (Remove references to `./tmp` in-tree)
 - rust-lang#98602 (Add regression test for rust-lang#80074)
 - rust-lang#98606 (:arrow_up: rust-analyzer)
 - rust-lang#98609 (Fix ICE for associated constant generics)
 - rust-lang#98611 (Fix glob import ICE in rustdoc JSON format)
 - rust-lang#98617 (Remove feature `const_option` from std)
 - rust-lang#98619 (Fix mir-opt wg name)
 - rust-lang#98621 (llvm-wrapper: adapt for removal of the ASanGlobalsMetadataAnalysis LLVM API)
 - rust-lang#98623 (fix typo in comment)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit db872ee into rust-lang:master Jun 28, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants